Skip to content

Restrict access to MemoryResourceProxy in ManagedMemoryResource#52

Closed
jorgecasal wants to merge 2 commits intoeclipse-score:mainfrom
etas-contrib:feature/issue-94-memory-resource-proxy-visibility
Closed

Restrict access to MemoryResourceProxy in ManagedMemoryResource#52
jorgecasal wants to merge 2 commits intoeclipse-score:mainfrom
etas-contrib:feature/issue-94-memory-resource-proxy-visibility

Conversation

@jorgecasal
Copy link
Contributor

This pull request removes the public visibility of getMemoryResourceProxy() in ManagedMemoryResource and changes the PolymorphicOffsetPtrAllocator constructor to accept ManagedMemoryResource instead of a proxy pointer. Only PolymorphicOffsetPtrAllocator is allowed to call getMemoryResourceProxy() via friend class access.

resolves #94

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

The created documentation from the pull request is available at: docu-html

@fbaeuerle
Copy link
Contributor

Hi @jorgecasal, this change looks great – Thanks!
I am keen to import your change into our internal repository via copybara and export it back to baselibs.
In order to do so, I would like to ask you to squash your commits together (or rebase them in a suitable way, the merge-commit is likely to cause trouble otherwise).

@jorgecasal jorgecasal force-pushed the feature/issue-94-memory-resource-proxy-visibility branch from be91425 to aef8f12 Compare February 17, 2026 14:08
@jorgecasal jorgecasal force-pushed the feature/issue-94-memory-resource-proxy-visibility branch from aef8f12 to 3b37e47 Compare February 17, 2026 14:26
@jorgecasal jorgecasal force-pushed the feature/issue-94-memory-resource-proxy-visibility branch from 3b37e47 to aef8f12 Compare February 17, 2026 14:27
- Restrict MemoryResourceProxy access via private method and friend allocator
- Deprecate raw pointer PolymorphicOffsetPtrAllocator constructor
- Remove deprecated raw pointer constructor from PolymorphicOffsetPtrAllocator
- Update PUML diagrams to reflect new allocator API
- Fix allocator test helper to use new ManagedMemoryResource constructor
@jorgecasal jorgecasal force-pushed the feature/issue-94-memory-resource-proxy-visibility branch from aef8f12 to 6726d5f Compare February 17, 2026 14:29
…ility

Signed-off-by: Jorge C. Santos <156771132+jorgecasal@users.noreply.github.com>
@jorgecasal
Copy link
Contributor Author

Hi @fbaeuerle, thanks for the feedback!
I've squashed the commits into a single one. Let me know if you need anything else.

@4og 4og moved this to On Hold in BAS - Baselibs FT Feb 20, 2026
@fbaeuerle
Copy link
Contributor

Hi @jorgecasal,
currently, no further action from your side is needed. I also adapted communication (and the other users) because the code is stored in the same repository internally. I have to get this through code review and afterwards I will export it back to baselibs using copybara. It will, however, take some more additional time.

@fbaeuerle
Copy link
Contributor

Hi @jorgecasal,
We successfully integrated your change and exported it back to baselibs via copybara:
1198d85

I also adapted communication to your change, my coworker will export that change soon.

@fbaeuerle fbaeuerle closed this Feb 27, 2026
@github-project-automation github-project-automation bot moved this from On Hold to Done in BAS - Baselibs FT Feb 27, 2026
@jorgecasal
Copy link
Contributor Author

Hi @fbaeuerle,
Can you confirm that issue eclipse-score/communication#94 will be resolved by your coworker's changes, and no further action is needed from my side?
Thanks!

@fbaeuerle
Copy link
Contributor

Yes, basically the code in communication will adhere to the changed class interface that you contributed to baselibs. The
code lives in the same repo internally, so I had to adapt this in order to integrate it.

Whereas I am one of the persons responsible for importing from/exporting to baselibs, there's a bunch of coworkers responsible for this task in the communication repository.

I will double check this after it was exported. It can happen that some part of communication exempt from the sync to the internal repository needs adaptation, but @Rahul-Sutariya will find that out when exporting the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Restrict access to MemoryResourceProxy in ManagedMemoryResource

2 participants