Restrict access to MemoryResourceProxy in ManagedMemoryResource#52
Conversation
|
The created documentation from the pull request is available at: docu-html |
|
Hi @jorgecasal, this change looks great – Thanks! |
be91425 to
aef8f12
Compare
aef8f12 to
3b37e47
Compare
3b37e47 to
aef8f12
Compare
- Restrict MemoryResourceProxy access via private method and friend allocator - Deprecate raw pointer PolymorphicOffsetPtrAllocator constructor - Remove deprecated raw pointer constructor from PolymorphicOffsetPtrAllocator - Update PUML diagrams to reflect new allocator API - Fix allocator test helper to use new ManagedMemoryResource constructor
aef8f12 to
6726d5f
Compare
…ility Signed-off-by: Jorge C. Santos <156771132+jorgecasal@users.noreply.github.com>
|
Hi @fbaeuerle, thanks for the feedback! |
|
Hi @jorgecasal, |
|
Hi @jorgecasal, I also adapted communication to your change, my coworker will export that change soon. |
|
Hi @fbaeuerle, |
|
Yes, basically the code in communication will adhere to the changed class interface that you contributed to baselibs. The Whereas I am one of the persons responsible for importing from/exporting to baselibs, there's a bunch of coworkers responsible for this task in the communication repository. I will double check this after it was exported. It can happen that some part of communication exempt from the sync to the internal repository needs adaptation, but @Rahul-Sutariya will find that out when exporting the change. |
This pull request removes the public visibility of
getMemoryResourceProxy()inManagedMemoryResourceand changes thePolymorphicOffsetPtrAllocatorconstructor to acceptManagedMemoryResourceinstead of a proxy pointer. OnlyPolymorphicOffsetPtrAllocatoris allowed to callgetMemoryResourceProxy()via friend class access.resolves #94